impr: OpenAPI generates requestBody for every POST request

Urigo · May 29, 2019 · d02deb6 · d02deb6
1 parent f7e4ece
commit d02deb6
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/src/open-api/index.ts b/src/open-api/index.ts
@@ -55,6 +55,7 @@ export function OpenAPI({
         url: path,
         operation: info.document,
         schema,
+        useRequestBody: info.method === 'POST',
       });
     },
     get() {

diff --git a/src/open-api/operations.ts b/src/open-api/operations.ts
@@ -14,20 +14,21 @@ export function buildPathFromOperation({
   url,
   schema,
   operation,
+  useRequestBody,
 }: {
   url: string;
   schema: GraphQLSchema;
   operation: DocumentNode;
+  useRequestBody: boolean;
 }) {
   const info = getOperationInfo(operation)!;
-  const isQuery = info.operation.operation === 'query';
 
   return {
     operationId: info.name,
-    parameters: isQuery
+    parameters: !useRequestBody
       ? resolveParameters(url, info.operation.variableDefinitions)
       : [],
-    requestBody: !isQuery
+    requestBody: useRequestBody
       ? {
           content: {
             'application/json': {

diff --git a/tests/open-api/operations.spec.ts b/tests/open-api/operations.spec.ts
@@ -37,6 +37,7 @@ test('handle query', async () => {
     url: '/api/feed',
     operation,
     schema,
+    useRequestBody: false,
   });
 
   expect(result.operationId).toEqual('feedQuery');
@@ -70,6 +71,7 @@ test('handle mutation', async () => {
     url: '/api/add-post',
     operation,
     schema,
+    useRequestBody: true,
   });
 
   // id
-Original file line number
+Diff line change
@@ Expand Up / @@ -55,6 +55,7 @@ export function OpenAPI({ @@
             url: path,
             operation: info.document,
             schema,
+            useRequestBody: info.method === 'POST',
           });
         },
         get() {
@@ Expand Down @@