Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Augments colcon pkg with dependencies from pyproject file. #38

Merged

Conversation

francocipollone
Copy link
Contributor

Related to #37

Summary

This PR introduces the ability to indicate the colcon/ros dependencies of the project via the pyproject.toml file.
Otherwise, dependencies for the package aren't loaded up, and the ordering when building isn't respected

Use

Add to pyproject.toml the following section:

[colcon-package]
depend = ["another_pkg_1"]   # This will add to both `build_depend` and `exec_depend` following `package.xml` standards
build_depend = ["another_pkg_2"]
exec_depend = ["another_pkg_3"]
test_depend = ["another_pkg_4"]

Copy link
Member

@velovix velovix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this!

colcon_poetry_ros/package_augmentation/poetry.py Outdated Show resolved Hide resolved
Signed-off-by: Franco Cipollone <[email protected]>
@francocipollone francocipollone requested a review from velovix July 10, 2023 16:16
@velovix velovix merged commit 1e7f10e into UrbanMachine:main Jul 10, 2023
@francocipollone
Copy link
Contributor Author

francocipollone commented Jul 11, 2023

Thanks @velovix for the prompt review and merge and also for adding documentation I missed. 💯

Are you planning a patch/minor release shortly to incorporate these changes?

velovix pushed a commit that referenced this pull request Jul 11, 2023
There was a bug incorporated in the last commit of #38
This PR fixes that issue. I already tested it out.

Signed-off-by: Franco Cipollone <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants