Skip to content

Commit

Permalink
update cran-comments for #118 [ci skip]
Browse files Browse the repository at this point in the history
  • Loading branch information
mpadge committed Oct 28, 2024
1 parent 9b2ef16 commit 9bd95c2
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: gtfsrouter
Title: Routing with 'GTFS' (General Transit Feed Specification) Data
Version: 0.1.2.019
Version: 0.1.2.020
Authors@R: c(
person("Mark", "Padgham", , "[email protected]", role = c("aut", "cre")),
person("Marcin", "Stepniak", , "[email protected]", role = "aut",
Expand Down
2 changes: 1 addition & 1 deletion codemeta.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"codeRepository": "https://github.com/UrbanAnalyst/gtfsrouter",
"issueTracker": "https://github.com/UrbanAnalyst/gtfsrouter/issues",
"license": "https://spdx.org/licenses/GPL-3.0",
"version": "0.1.2.019",
"version": "0.1.2.020",
"programmingLanguage": {
"@type": "ComputerLanguage",
"name": "R",
Expand Down
4 changes: 2 additions & 2 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# CRAN notes for gtfsrouter_0.1.2 submission
# CRAN notes for gtfsrouter_0.1.3 submission

This submission fixes UBSAN errors from previous, recent submission. It documents return values on all functions, as suggested in email from Benjamin Altmann, and also rectifies the package documentation in the man/ entry, as recommended in recent email from Kurt Hornik. The request to ensure user options are reset arises only from hard-coding 'data.table::setDTthreads(1L)' throughout entire package, as recently discussed at great length on r-pkg-devel mailing list. This re-submission also resets values to initial value of 'getDTthreads()', which should also rectify that issue.
The current CRAN version generates NOTEs on some systems regarding large sizes of both "docs" and "libs" directories. These are unavoidable, as the package contains a large C++ code base, and also requires extensive documentation. The "docs" folders contain only 4 images generated by "ggplot2", which are relatively simple and already as small as possible in size.

Other than that, this submission generates no additional notes or warnings on:

Expand Down

0 comments on commit 9bd95c2

Please sign in to comment.