-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
12 task 2b primary locations work #15
Conversation
A couple of errors thrown by ruff that I think we could relax:
What do you think @sgreenbury ? |
@Hussein-Mahfouz: this looks great, I have updated the notebook and scripts the following changes:
It might be worth refactoring the scripts more extensively so their purpose is solely for processing the data (e.g. remove plots and other interactive aspects), but I think this would be better to look at in a new issue/PR. |
Nice one! Happy to merge this :)
Yes agreed let's keep this one for a different PR. As discussed, the contents of the scripts might change so that we are dealing with all primary trips together |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Hussein-Mahfouz, will go ahead and merge this now.
When complete, this PR will allow us to assign people to actual primary locations. See #12 for details