Remove resolved todo

Urban-Analytics-Technology-Platform · Nov 1, 2024 · f5b159c · f5b159c
1 parent 82850ee
commit f5b159c
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 7 deletions.
diff --git a/scripts/2_match_households_and_individuals.py b/scripts/2_match_households_and_individuals.py
@@ -879,11 +879,7 @@ def get_interim_path(
         ) as f:
             matches_hh_level_sample_list = pkl.load(f)
 
-    # TODO: check if this:
-    #   - column is required and possibly update other scripts to add this column in-memory since it is large
-    #   - or can use the single sample hh for the new column
-    # For now, updated to use the sample dictionary
-    ## add matches_hh_level as a column in spc_edited
+    ## add matches_hh_level_sample as a column in spc_edited
     spc_edited["nts_hh_id"] = spc_edited["hid"].map(matches_hh_level_sample)
 
     # Do the same at the df level. Add nts_hh_id_sample column to the spc df

diff --git a/scripts/3.2.3_assign_secondary_zone.py b/scripts/3.2.3_assign_secondary_zone.py
@@ -224,7 +224,6 @@ def merge_columns_from_other(df: pd.DataFrame, other: pd.DataFrame) -> pd.DataFr
             "id",
             "household",
             "nts_ind_id",
-            # TODO: check if this column is required
             "nts_hh_id",
             "age_years",
             "oact",

diff --git a/src/acbm/assigning/utils.py b/src/acbm/assigning/utils.py
@@ -14,7 +14,6 @@ def cols_for_assignment_all() -> list[str]:
         "household",
         "oact",
         "nts_ind_id",
-        # TODO: check if this column is required
         "nts_hh_id",
         "age_years",
         "TripDisIncSW",