Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell scripts should be treated like text #44

Open
expectocode opened this issue Jan 25, 2016 · 3 comments
Open

Shell scripts should be treated like text #44

expectocode opened this issue Jan 25, 2016 · 3 comments

Comments

@expectocode
Copy link

I love my up1 instance and use it a fair bit, but i find that i can't share .sh files as easily as i'd like.
This should be a simple fix, please implement.

@andre-d
Copy link
Contributor

andre-d commented Jan 25, 2016

Ah your browser calls them "application/" I will add it to the exception
list.
On Jan 25, 2016 5:54 PM, "expectocode" [email protected] wrote:

I love my up1 instance and use it a fair bit, but i find that i can't
share sh files as easily as i'd like
This should be a simple fix, please implement


Reply to this email directly or view it on GitHub
#44.

@expectocode
Copy link
Author

Ah, good good. I was trying to fix it with

  'text/x-shellscript': 'text',

@andre-d
Copy link
Contributor

andre-d commented Jan 25, 2016

Browsers are giving them a blank mime type, I recall seeing when I developed the logic originally that it ran a check for null bytes and called it text/plain if it had none but binary otherwise..but I am not seeing that....just an empty mime type in FF and Chrome..I will look into running that check myself for small files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants