Fix issue when gliding down vines with Elytra

Don't flag for FakeFall if the player is to/from a climbable. Not sure the issue that would cause NoFall to be out of sync but not going to be concerned since this is the only issue reported.
Updated-NoCheatPlus · May 9, 2020 · 72f26af · 72f26af
1 parent 1aee48a
commit 72f26af
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/NCPCore/src/main/java/fr/neatmonster/nocheatplus/checks/moving/MovingListener.java b/NCPCore/src/main/java/fr/neatmonster/nocheatplus/checks/moving/MovingListener.java
@@ -2367,6 +2367,15 @@ private void checkFallDamageEvent(final Player player, final EntityDamageEvent e
                     if (debug) {
                         debug(player, "NoFall/Damage: allow fall damage in lava (hotfix).");
                     }
+                } else if (moveInfo.to.isOnClimbable() && moveInfo.from.isOnClimbable()) {
+
+                    // Fix issues when gliding down vines with elytra.
+                    // TODO: Maybe more conditions to check to see if the player was gliding?
+                    // Checking for velocity does not work since sometimes it can be applied after this check runs
+
+                    if (debug) {
+                        debug(player, "Ignore fakefall on climbable");
+                    }
                 }
                 else if (noFallVL(player, "fakefall", data, cc)) {
                     // NOTE: Double violations are possible with the in-air check below.