Use a persistent session when making requests #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-uoa
force-pushed
the
persistent_request_session
branch
from
6d3e9da to
02b714c
Compare
andrew-uoa
force-pushed
the
persistent_request_session
branch
3 times, most recently
from
e49441f to
d79fe58
Compare
…cycling the HTTP connection
…t conditional branch
andrew-uoa
force-pushed
the
persistent_request_session
branch
from
d79fe58 to
a42ca8b
Compare
JLoveUOA
pushed a commit
that referenced
this pull request
Jan 24, 2024
* Use a persistent session when making requests, to speed them up by recycling the HTTP connection * Move session initialization to the constructor, and remove a redundant conditional branch * Fix the test mock patching to reflect changes to which request method we're calling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the MyTardis client class (MyTardisRESTFactory) so that it creates a requests
Sessionobject on construction, and uses this session for all of its requests. This speeds up requests, as otherwise, usng the defaultrequests.request(...), a new HTTP connection is created every time a request is made.It's worth noting that the session object is not just for persisting the HTTP connection; it also persists cookies etc. It seems unlikely this would cause problems, and I haven't seen any.
Documentation for the
Sessionobject can be found here:https://requests.readthedocs.io/en/latest/user/advanced/