Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDS-961 Create models for put requests #11

Merged
merged 8 commits into from
Dec 3, 2024

Conversation

uoa-noel
Copy link
Member

@uoa-noel uoa-noel commented Nov 28, 2024

This PR adds a data model to represent form submissions from the front end, with information about retention period and data classification. It initially had validation rules around custom retention period justification but was removed due to problems with SQLModel library. This may be addressed in a separate PR.

@uoa-noel uoa-noel changed the title Ids 961 change models for put requests IDS-961 Create models for put requests Dec 2, 2024
@uoa-noel uoa-noel marked this pull request as ready for review December 2, 2024 21:37
Copy link
Contributor

@JLoveUOA JLoveUOA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, your call if you want to refactor to add a BaseDriveOffboardSubmission if you plan on adding an InputDriveOffboardSubmission later.

pyproject.toml Outdated Show resolved Hide resolved
src/models/submission.py Show resolved Hide resolved
@uoa-noel uoa-noel merged commit eb0f329 into main Dec 3, 2024
1 check passed
@uoa-noel uoa-noel deleted the IDS-961-change-models-for-put-requests branch December 3, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants