Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDS-956 implement validations in pages #10

Merged
merged 14 commits into from
Dec 2, 2024

Conversation

uoa-noel
Copy link
Member

@uoa-noel uoa-noel commented Nov 25, 2024

This PR implements basic validation of user entry in the form. As part of the change, it also creates data models for Project and Drive information, and the pages now make use of the models.
Input for title, description change and custom retention period are also implemented. Member and division changes have not yet been implemented due to complexity - they should be addressed in a separate PR.
The app also reminds user of unsaved changes if they try to close the page before submission.
Some style changes are also made.

@uoa-noel uoa-noel changed the title Ids 956 implement validations in pages IDS-956 implement validations in pages Nov 26, 2024
@uoa-noel uoa-noel marked this pull request as ready for review November 26, 2024 21:59
@uoa-noel uoa-noel requested a review from JLoveUOA November 26, 2024 22:00
@JLoveUOA
Copy link
Contributor

One or two little tidy up things for consistency but otherwise looks good (for my ability to test and check vue)

Copy link
Contributor

@JLoveUOA JLoveUOA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but probably worth commenting out the /update members link in the router as there isn't a .vue file for it in this commit (although I suspect it will be coming in the next one)

web/src/router/index.ts Outdated Show resolved Hide resolved
web/src/views/CheckDetailsView.vue Show resolved Hide resolved
@uoa-noel uoa-noel merged commit a71fbf9 into main Dec 2, 2024
@uoa-noel uoa-noel deleted the IDS-956-implement-validations-in-pages branch December 2, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants