Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/contain nltk assets in docker image #3853

Merged
merged 39 commits into from
Jan 8, 2025
Merged
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
3d9e013
feat:contain nltk data in docker image
christinestraub Dec 24, 2024
3c7985f
fix test dockerfile errors
christinestraub Dec 24, 2024
8ee6a2b
feat:using nltk assets in docker image
christinestraub Dec 26, 2024
2ed5675
feat:fix makefile error
christinestraub Dec 26, 2024
c482698
test:fix lint errors
christinestraub Dec 26, 2024
9d1a57d
test:fix test_dockerfile error
christinestraub Dec 27, 2024
27eea08
feat:integrate nltk data into docker image
christinestraub Jan 2, 2025
6b1ee55
test:fix version
christinestraub Jan 3, 2025
03a0adf
feat:fix nltk data path
christinestraub Jan 3, 2025
9c42660
feat:fix ingest test errors
christinestraub Jan 3, 2025
efe1167
feat:update dockerfile
christinestraub Jan 3, 2025
b961399
test: fix lint errors
christinestraub Jan 3, 2025
e7333e6
test:fix dockerfile errors
christinestraub Jan 3, 2025
dad9f87
feat:update ability to validate nltk assets
christinestraub Jan 3, 2025
f37a922
test:fix lint errors
christinestraub Jan 3, 2025
908c9e7
feat:fix nltk path error
christinestraub Jan 6, 2025
494b0e0
fix conflicts error
christinestraub Jan 6, 2025
30198a7
Merge branch 'main' into feat/contain-nltk-assets-in-docker-image
christinestraub Jan 6, 2025
39187d0
feat:add nltk model installation logic
christinestraub Jan 6, 2025
915b0ce
feat:revert ci.yml
christinestraub Jan 6, 2025
f4611a1
feat:revert Makefile
christinestraub Jan 6, 2025
2471633
feat:fix ingest test errors
christinestraub Jan 6, 2025
28262a4
feat:fix ingest test errors
christinestraub Jan 6, 2025
f778c0a
test:fix lint errors
christinestraub Jan 6, 2025
648c24a
test:fix lint errors
christinestraub Jan 6, 2025
a456d4e
feat: revert test function
christinestraub Jan 6, 2025
c2616cc
test:fix unit errors
christinestraub Jan 6, 2025
a4c4cbb
commented ondrive sh
christinestraub Jan 6, 2025
26b42d8
commented outlook sh
christinestraub Jan 6, 2025
82f16ec
commented outlook sh
christinestraub Jan 6, 2025
8b2f950
feat:update dockerfile and tokenize.py
christinestraub Jan 6, 2025
c7942ad
feat:update download_nltk_packages()
christinestraub Jan 6, 2025
8d57220
added changes as per the suggestion
christinestraub Jan 7, 2025
95358e0
updated code as per suggestion
christinestraub Jan 7, 2025
6e9931a
modified .gitignore
christinestraub Jan 7, 2025
7eeb411
removed if statement in tokenize
christinestraub Jan 7, 2025
26854e5
removed unused vars and function
christinestraub Jan 7, 2025
f340d65
remove download check function from test_tokenize
christinestraub Jan 7, 2025
2830248
Update CHANGELOG.md
christinestraub Jan 7, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update CHANGELOG.md
christinestraub authored Jan 7, 2025
commit 283024832c60f3ae485a8419b055d83a314ef154
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -7,7 +7,8 @@
### Fixes

- **Fix NLTK Download** to use nltk assets in docker image

- removed the ability to automatically download nltk package if missing

## 0.16.12

### Enhancements