chore: add auth to s3 destination test #3122

ryannikolaidis · 2024-05-30T17:00:17Z

We should be validating the S3 Destination with authenticated requests, with credentials from a limited test user.

Changes

Updates s3 destination test to point to a bucket that requires authentication.
Adds authentication to the s3 destination test request
Bonus: fix deserialization of S3ConnectionConfig for s3 V2 destination
Bonus: fix S3ConnectionConfig never registered for s3 V2 destination
Bonus: repair version and changelog version for consistency with -dev convention

Testing

Validated by changes to S3 destination ingest test

CHANGELOG.md

ryannikolaidis had a problem deploying to ci May 30, 2024 17:01 — with GitHub Actions Failure

ryannikolaidis had a problem deploying to ci May 30, 2024 17:01 — with GitHub Actions Error

ryannikolaidis had a problem deploying to ci May 30, 2024 17:30 — with GitHub Actions Failure

ryannikolaidis had a problem deploying to ci May 30, 2024 17:30 — with GitHub Actions Error

ryannikolaidis had a problem deploying to ci May 30, 2024 18:34 — with GitHub Actions Failure

ryannikolaidis had a problem deploying to ci May 30, 2024 18:34 — with GitHub Actions Error

ryannikolaidis had a problem deploying to ci May 30, 2024 18:53 — with GitHub Actions Failure

ryannikolaidis had a problem deploying to ci May 30, 2024 19:11 — with GitHub Actions Failure

ryannikolaidis had a problem deploying to ci May 30, 2024 19:11 — with GitHub Actions Error

ryannikolaidis had a problem deploying to ci May 30, 2024 20:01 — with GitHub Actions Failure

ryannikolaidis had a problem deploying to ci May 30, 2024 20:01 — with GitHub Actions Error

ryannikolaidis had a problem deploying to ci May 30, 2024 20:14 — with GitHub Actions Error

ryannikolaidis had a problem deploying to ci May 30, 2024 20:14 — with GitHub Actions Failure

ryannikolaidis had a problem deploying to ci May 30, 2024 20:23 — with GitHub Actions Failure

ryannikolaidis had a problem deploying to ci May 30, 2024 20:23 — with GitHub Actions Error

ryannikolaidis had a problem deploying to ci May 30, 2024 20:35 — with GitHub Actions Error

ryannikolaidis had a problem deploying to ci May 30, 2024 20:35 — with GitHub Actions Failure

ryannikolaidis had a problem deploying to ci May 30, 2024 21:20 — with GitHub Actions Error

ryannikolaidis had a problem deploying to ci May 30, 2024 21:20 — with GitHub Actions Failure

ryannikolaidis had a problem deploying to ci May 30, 2024 21:39 — with GitHub Actions Failure

ryannikolaidis had a problem deploying to ci May 30, 2024 21:50 — with GitHub Actions Error

ryannikolaidis had a problem deploying to ci May 30, 2024 21:50 — with GitHub Actions Failure

ryannikolaidis had a problem deploying to ci May 30, 2024 22:04 — with GitHub Actions Failure

ryannikolaidis had a problem deploying to ci May 30, 2024 22:04 — with GitHub Actions Error

ryannikolaidis temporarily deployed to ci May 30, 2024 23:56 — with GitHub Actions Inactive

ryannikolaidis had a problem deploying to ci May 30, 2024 23:57 — with GitHub Actions Failure

ryannikolaidis had a problem deploying to ci May 31, 2024 00:11 — with GitHub Actions Error

ryannikolaidis had a problem deploying to ci May 31, 2024 00:11 — with GitHub Actions Failure

ryannikolaidis marked this pull request as ready for review May 31, 2024 04:42

ryannikolaidis had a problem deploying to ci May 31, 2024 04:43 — with GitHub Actions Error

ryannikolaidis had a problem deploying to ci May 31, 2024 04:43 — with GitHub Actions Failure

rbiseck3 approved these changes May 31, 2024

View reviewed changes

change bucket

aac0148

ryannikolaidis had a problem deploying to ci May 31, 2024 04:53 — with GitHub Actions Error

ryannikolaidis had a problem deploying to ci May 31, 2024 04:53 — with GitHub Actions Failure

Merge branch 'main' into ryan/add-auth-to-s3-test

d98dddd

ryannikolaidis enabled auto-merge May 31, 2024 05:05

ryannikolaidis had a problem deploying to ci May 31, 2024 05:06 — with GitHub Actions Failure

ryannikolaidis had a problem deploying to ci May 31, 2024 05:06 — with GitHub Actions Error

ryannikolaidis had a problem deploying to ci May 31, 2024 05:16 — with GitHub Actions Failure

ryannikolaidis had a problem deploying to ci May 31, 2024 05:16 — with GitHub Actions Error

ryannikolaidis had a problem deploying to ci May 31, 2024 05:27 — with GitHub Actions Failure

ryannikolaidis had a problem deploying to ci May 31, 2024 05:27 — with GitHub Actions Error

change bucket

6710913

ryannikolaidis temporarily deployed to ci May 31, 2024 05:37 — with GitHub Actions Inactive

cragwolfe reviewed May 31, 2024

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

ryannikolaidis disabled auto-merge May 31, 2024 06:08

dev3

dc0c406

ryannikolaidis enabled auto-merge May 31, 2024 06:10

ryannikolaidis temporarily deployed to ci May 31, 2024 06:12 — with GitHub Actions Inactive

ryannikolaidis temporarily deployed to ci May 31, 2024 06:46 — with GitHub Actions Inactive

ryannikolaidis added this pull request to the merge queue May 31, 2024

Merged via the queue into main with commit 1f87687 May 31, 2024
46 checks passed

ryannikolaidis deleted the ryan/add-auth-to-s3-test branch May 31, 2024 07:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: add auth to s3 destination test #3122

chore: add auth to s3 destination test #3122

ryannikolaidis commented May 30, 2024 •

edited

Loading

chore: add auth to s3 destination test #3122

chore: add auth to s3 destination test #3122

Conversation

ryannikolaidis commented May 30, 2024 • edited Loading

Changes

Testing

ryannikolaidis commented May 30, 2024 •

edited

Loading