enhancement: partitoin_pdf() skip unnecessary element sorting
#3030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christinestraub
changed the title
partitoin_pdf() skip unnecessary embedded text sortingpartitoin_pdf() skip unnecessary element sorting
cragwolfe
approved these changes
May 16, 2024
christinestraub
deleted the
feat/pdf-skip-unnecessary-embedded-text-sorting
branch
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 17, 2024
…eline (#3040) This PR aims to pass `kwargs` through `fast` strategy pipeline, which was missing as part of the previous PR - #3030. I also did some code refactoring in this PR, so I recommend reviewing this PR commit by commit. ### Summary - pass `kwargs` through `fast` strategy pipeline, which will allow users to specify additional params like `sort_mode` - refactor: code reorganization - cut a release for `0.14.0` ### Testing CI should pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to skip element sorting when determining whether embedded text can be extracted. The extracted elements in this step are returned as final elements only for the
faststrategy pipeline and are never used for other strategy pipelines (hi_res,ocr).Removing element sorting in this step and adding it to the
faststrategy pipeline later will improve performance and reduce execution time.Summary
_partition_pdf_with_pdfparser()function for fast` strategy pipelineTesting
CI should pass.