Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License questions regarding pillow-heif #2664

Closed
joennlae opened this issue Mar 18, 2024 · 6 comments · Fixed by #3571
Closed

License questions regarding pillow-heif #2664

joennlae opened this issue Mar 18, 2024 · 6 comments · Fixed by #3571

Comments

@joennlae
Copy link

First of all, really cool software 💯

While doing a license check, I noticed that the pillow-heif dependency is actually GPLv2 with the binary wheels.

Source: bigcat88/pillow_heif#111

I think we should use pi-heif: https://pypi.org/project/pi-heif/ but IANAL :-)

Just thought it would make sense to communicate that while I stumbled upon it.

@MthwRobinson
Copy link
Contributor

@joennlae - Thanks for reporting this! pillow_heif looks like it has a BSD license, which is one of the license we accept for dependencies. The bindings to GPL licensed system dependencies are good to go from our stand point.

@PhorstenkampFuzzy
Copy link

For us it looks like the code has a BSD license but the Wheel has a GPLV2. How do you reconsile this?

@nylocx
Copy link

nylocx commented Aug 27, 2024

We came across the same issue and would have to patch unstructured as the binary wheels for pillow-heif is GPLv2 licensed. The author of pillow-heif is releasing pi-heif with the info:

This is a light version of Pillow-Heif with more permissive license for binary wheels. [...] All codebase are the same, refer to pillow-heif docs.

So please reconsider changing the dependency as it should be a drop in replacement and resolve GPL compatibility issues.

@MthwRobinson
Copy link
Contributor

Thanks for the clarification. We're working on replacing pillow-heif with pi-heif.

@MthwRobinson MthwRobinson reopened this Aug 27, 2024
@PhorstenkampFuzzy
Copy link

🙇

github-merge-queue bot pushed a commit that referenced this issue Aug 27, 2024
### Summary

Closes #2664 and replaces `pillow-heif` with `pi-heif` due to more
permissive licensing on the binary wheel for `pi-heif`.
MthwRobinson added a commit that referenced this issue Aug 27, 2024
### Summary

Closes #2664 and replaces `pillow-heif` with `pi-heif` due to more
permissive licensing on the binary wheel for `pi-heif`.
@MthwRobinson
Copy link
Contributor

We're now using py-heif. That changed was released in 0.15.8. Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants