ci: remove ingest tests job from CI workflow #340
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These ingests tests have been failing for a while now and were not required for merge. As we have no immediate intention of fixing these and their value in this context is doubtful, remove them.
|
If we're merging PRs even though it's failing for me it means we can remove it. |
|
@amadeusz-ds I believe Crag was inclined for us to try to fix these rather than remove them. |
Anyone looked into this? I could work on that, but I don't see anything in the logs that might point to the source of the problem. |
|
Since this PR, @MthwRobinson disabled the tests, so I'm going to close this as moot for now. (Perfectly fine to reopen if we want the tests completely removed.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These ingests tests have been failing for a while now and were not required for merge. As we have no immediate intention of fixing these and their value in this context is doubtful, remove them.