Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove logger info for chipper since its private #278

Merged
merged 4 commits into from
Nov 6, 2023
Merged

chore: remove logger info for chipper since its private #278

merged 4 commits into from
Nov 6, 2023

Conversation

yuming-long
Copy link
Contributor

Remove the logger info that user won't be able to see since chipper is only available in host API.

@yuming-long yuming-long requested a review from qued November 6, 2023 15:31
qued
qued approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@qued qued left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@yuming-long yuming-long merged commit 76f9900 into main Nov 6, 2023
5 of 8 checks passed
@yuming-long yuming-long deleted the yuming/remove_chipper_logger branch November 6, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qued qued qued approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuming-long @qued