Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: better error message on image/page extraction mismatch #276

Merged
merged 3 commits into from
Nov 3, 2023

Conversation

qued
Copy link
Contributor

@qued qued commented Nov 3, 2023

Removed the reference to Poppler in error message when number of images extracted doesn't match the number of page layouts extracted (I'm no longer confident that this is caused by Poppler not being installed). Also provided some details in the message about how many of each were extracted, and updated the test associated with this error.

Testing:

Updated CI test should pass.

@qued qued requested a review from amanda103 November 3, 2023 16:12
Copy link

@amanda103 amanda103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending passing builds 🥳

@qued qued merged commit 008b6af into main Nov 3, 2023
@qued qued deleted the enhancement/better-error-message-extraction-mismatch branch November 3, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants