-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide Tauri integration behind feature flag #32
Comments
@Einliterflasche What do you think? |
Long term goal should probably be that tauri compilation works... But yeah, we could do that |
Regardless of the CI it does make sense to me to still be able to compile the project entirely without Tauri |
While that would be nice it would also require us to mark every bit of code that uses tauri functions with #[cfg(feat = tauri)]`, including imports... I mean, we could do that if we manage to keep the tauri code concentrated into a few areas |
We could also delegate the calling of the emit function on the tauri handle (implementation of TauriEmitter) to the src-tauri crate. That way 'swap' will only include the trait definition and will not depend on the 'tauri' crate. |
working on it in #37 |
We can hide the Tauri integration behind an optional
tauri-integration
feature flag. This would allow theswap
(cli and asb) crate to be compiled without having to compile thetauri
crate (meaning the library).If our long term goal is for this fork to replace upstream, it might be beneficial.
This would fix the currently failing CI build action: https://github.com/UnstoppableSwap/xmr-btc-swap/actions/runs/10563121578/job/29262633363
The text was updated successfully, but these errors were encountered: