Add routes support #133
Merged
Add routes support #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I doubt routes will come thick and fast, but most other decodes are protected with a striped mutex to ensure that there isn't a collision with simultaneous decode (you get a duplicate record error message usually when this happens, which usually goes away) |
Mygod
reviewed
Jul 27, 2023
|
No indexes yet for route retrieval |
jfberry
reviewed
Jul 28, 2023
jfberry
reviewed
Jul 28, 2023
Fabio1988
approved these changes
Jul 29, 2023
Routes can be returned in multiple cells. So now they're only counted once.
Mygod
reviewed
Jul 31, 2023
jfberry
approved these changes
Jul 31, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Golbat will now decode routes received through the
GetRoutesOutProto. The routes are saved in a new table calledroute.This PR closes issue #129.