Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ubuntu version from 18 to 22 and nodejs from 12 to 16 #77

Merged
merged 2 commits into from
Jan 3, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .eslintrc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ rules: # See https://eslint.org/docs/rules
quote-props:
- warn
- consistent-as-needed # Enforce consistency with quotes on props, either all must be quoted, or all unquoted for a given object
no-return-await: 0 # Useful before, but recent node.js enhancements make it useless on node 12+ (we use 10, but still, for consistency) - Read https://stackoverflow.com/questions/44806135/why-no-return-await-vs-const-x-await
no-extra-boolean-cast: 0 # Don't enforce, let developer choose. Using "!!!" is sometimes useful (edge cases), and has a semantic value (dev intention)
object-curly-newline:
- warn
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/auto-git-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ on:

jobs:
tag-and-release:
runs-on: ubuntu-18.04
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v2
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/auto-tag-on-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ on:

jobs:
actions-tagger:
runs-on: ubuntu-18.04
runs-on: ubuntu-22.04
steps:
- uses: Actions-R-Us/[email protected]
env:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/check-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ on:

jobs:
run-build-test:
runs-on: ubuntu-18.04
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v2
- run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/run-integration-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ on:

jobs:
run-integration-test:
runs-on: ubuntu-18.04
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v2
- run: yarn # Install all dependencies
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/update-codeclimate-coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,16 @@ jobs:
# Configures the deployment environment, install dependencies (like node, npm, etc.) that are requirements for the upcoming jobs
# Ex: Necessary to run `yarn test:coverage`
setup-environment:
name: Setup deployment environment (Ubuntu 18.04 - Node 12.x)
runs-on: ubuntu-18.04
name: Setup deployment environment (Ubuntu 22.04 - Node 16.x)
runs-on: ubuntu-22.04
steps:
- name: Installing node.js
uses: actions/[email protected] # Used to install node environment - XXX https://github.com/actions/setup-node
with:
node-version: '12.x' # Use the same node.js version as the one Vercel's uses (currently node12.x)
node-version: '16.x' # Use the same node.js version as the one Vercel's uses (currently node12.x)
run-tests-coverage:
name: Run tests coverage and send report to Code Climate
runs-on: ubuntu-18.04
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v1
- name: Installing dependencies
Expand Down
1 change: 1 addition & 0 deletions .nvmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
v16
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
```yaml
jobs:
wait-for-vercel-deployment:
runs-on: ubuntu-18.04
runs-on: ubuntu-22.04
steps:
- uses: UnlyEd/[email protected]
id: await-vercel
Expand Down Expand Up @@ -112,7 +112,7 @@ on:

jobs:
wait-for-vercel-deployment:
runs-on: ubuntu-18.04
runs-on: ubuntu-22.04
steps:
- name: Retrieve deployment URL (example on how to set an ENV var)
run: "echo VERCEL_DEPLOYMENT_URL=nextjs-bzyss249z.vercel.app >> $GITHUB_ENV"
Expand Down