chore: remove workaround

[thomasheartman]

This PR removes the workaround introduced in #6931. After https://github.com/ivarconr/unleash-enterprise/pull/1268 has been merged, this should be safe to apply.

Notably, this PR:

• tightens up the type for the enable change request function, so we can use that to inform the code
• skips trying to do anything with an empty array

The last point is less important than it might seem because both the env validation and the current implementation of the callback is essentially a no-op when there are no envs. However, that's hard to enforce. If we just exit out early, then at least we know nothing happens.

Optionally, we could do something like this instead, but I'm not sure it's better or worse. Happy to take input.

            const crEnvs = newProject.changeRequestEnvironments ?? []
            await this.validateEnvironmentsExist(crEnvs.map((env) => env.name));
            const changeRequestEnvironments =
                await enableChangeRequestsForSpecifiedEnvironments(crEnvs,);

            data.changeRequestEnvironments = changeRequestEnvironments;

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
unleash-docs	⬜️ Ignored (Inspect)	Visit Preview		Apr 26, 2024 5:41am
unleash-monorepo-frontend	⬜️ Ignored (Inspect)	Visit Preview		Apr 26, 2024 5:41am

[thomasheartman]

As mentioned in the description, this could be this instead (essentially the same as before, but without the comment and without extra set of ??s. Happy to hear your thoughts.

Suggested change

	if (newProject.changeRequestEnvironments) {
	await this.validateEnvironmentsExist(
	newProject.changeRequestEnvironments.map((env) => env.name),
	);
	const changeRequestEnvironments =
	await enableChangeRequestsForSpecifiedEnvironments(
	newProject.changeRequestEnvironments,
	);
	data.changeRequestEnvironments = changeRequestEnvironments;
	} else {
	data.changeRequestEnvironments = [];
	}
	const crEnvs = newProject.changeRequestEnvironments ?? []
	await this.validateEnvironmentsExist(crEnvs.map((env) => env.name));
	const changeRequestEnvironments =
	await enableChangeRequestsForSpecifiedEnvironments(crEnvs,);
	data.changeRequestEnvironments = changeRequestEnvironments;

I kinda like this version, because it avoids all the nesting and it reads cleaner to me 🤷🏼

[Tymek]

More verbose version looks more readable

[Tymek]

More verbose version looks more readable