Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix skeleton not appearing on feature toggle list #6093

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

sjaanus
Copy link
Contributor

@sjaanus sjaanus commented Jan 31, 2024

The FeatureToggleListTable is nested directly within PageContent. PageContent was cause for removing the skeleton from the table. However, this is unnecessary because the table has its own loader that manages the skeletons. Therefore, PageContent does not require a loader.

Copy link

vercel bot commented Jan 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 11:17am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Jan 31, 2024 11:17am

Copy link
Contributor

@kwasniew kwasniew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@sjaanus sjaanus merged commit 0f901bb into main Jan 31, 2024
14 checks passed
@sjaanus sjaanus deleted the fix-placeholder-feature branch January 31, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants