Support CockroachDB

[wodka]

So far it seems the only broken things are:

• Migrations (I needed to manually execute them and sometimes change the queries)
• Session handling is broken as knex-session misses the type on the first value (already created an issue there: Add cockroach support gx0r/connect-session-knex#84)

important is to pass the "version" do the db settings.

unleash
  .start({
    db: {
      version: '9.6',
    },
  })

Ideally the type should be updated to allow this without warnings.

[ivarconr]

Thanks. We are considering forking knex-session because we have outstanding issues that has not been solved.

[sergeyshaykhullin]

Any updates?

[ivarconr]

Sorry. The biggest blocker is the knex-session library that does not seem to respond to issues anymore. Thus we need to in-house that library to make progress.

We currently have two issues with that library that we would love to fix:

• Add cockroach support gx0r/connect-session-knex#84
• Unhandled rejection in dbCleanup gx0r/connect-session-knex#72

[wodka]

There is another problem:

there won't be support for skip lock in cockroach: cockroachdb/cockroach#40476

the FeatureToggleStore.setLastSeen used skipLocked: https://github.com/Unleash/unleash/blob/master/src/lib/db/feature-toggle-store.ts#L147

-> could we add an option to disable this?

for to possible pass this down to knex I added a ticket there as well: knex/knex#4899

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.