Skip to content
This repository has been archived by the owner on Dec 12, 2022. It is now read-only.

chore: automate Docker build & push #36

Merged
merged 5 commits into from
Feb 4, 2021
Merged

chore: automate Docker build & push #36

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
976a925
chore: automate Docker build & push
theneva Feb 2, 2021
2889f77
oops
theneva Feb 3, 2021
b6e864c
get unleash-server version in a less complicated way
theneva Feb 3, 2021
2df24ae
Update tools/docker-utils.js
theneva Feb 3, 2021
e678467
formatting
theneva Feb 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .dockerignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
tools/
node_modules/
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the build process runs npm ci anyways, so there's no real point to copying over 50 MB of node modules on every build

2 changes: 2 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
FROM node:12-alpine

ENV NODE_ENV production
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this prevents dev deps from getting installed 😄


COPY package.json package-lock.json ./

RUN npm ci
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ We have set up `docker-compose` to start postgres and the unleash server togethe
unleash locally without setting up a database or node.

```bash
$ docker-compose build
$ docker-compose build
chriswk marked this conversation as resolved.
Show resolved Hide resolved
$ docker-compose up
```

Expand Down
Loading