Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

localOption (HideSuccesses True) doesn't appear to work #231

Open
dustin opened this issue Dec 2, 2018 · 2 comments
Open

localOption (HideSuccesses True) doesn't appear to work #231

dustin opened this issue Dec 2, 2018 · 2 comments
Labels
command-line options

Comments

@dustin
Copy link

dustin commented Dec 2, 2018

I've got a test that has about 4,000 cases I'm trying to fix. It's a generated subsuite and I'd really like to not see it unless something is broken.

-ta --hide-successes works but just prefixing this particular bit with localOption (HideSuccesses True) doesn't.

e.g.:

testPartialTable :: [TestTree]
testPartialTable = undefined

[...]

localOption (HideSuccesses True) $ testGroup "partial table" testPartialTable,
@UnkindPartition
Copy link
Owner

Yes, HideSuccesses is a global option at the moment. It's possible to make it local, though that'd be a bit involved. Feel free to give it a try, the relevant code is in core/Test/Tasty/Ingredients/ConsoleReporter.hs.

dustin added a commit to dustin/tasty that referenced this issue Dec 13, 2018
@dustin
Support local options in consoleOutput
9577a35 
In particular, this addresses UnkindPartition#231 by allowing HideSuccesses to be
honored at result reporting time.
@dustin dustin mentioned this issue Dec 13, 2018
Closed
dustin added a commit to dustin/tasty that referenced this issue Dec 13, 2018
@dustin
Support local options in consoleOutput
0b62297 
In particular, this addresses UnkindPartition#231 by allowing HideSuccesses to be
honored at result reporting time.
@sjakobi sjakobi mentioned this issue Jul 11, 2020
Closed
@quchen
Copy link
Contributor

quchen commented Feb 4, 2022

Just stumbled upon this, the option still does not work (tasty 1.4.2.1).

quchen added a commit to quchen/tasty that referenced this issue Feb 4, 2022
@quchen
Document that HideSuccesses is only valid as a global option
eb4c684 
UnkindPartition#231
@quchen quchen mentioned this issue Feb 4, 2022
Merged
UnkindPartition pushed a commit that referenced this issue Feb 7, 2022
@quchen @UnkindPartition
Document that HideSuccesses is only valid as a global option
16289a7 
#231
@Bodigrim Bodigrim mentioned this issue Jun 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
command-line options
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dustin @UnkindPartition @Bodigrim @quchen