Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OOD-11: admin can fetch users from Sisu and add to Oodikone user-db #4528

Merged
merged 21 commits into from
Jun 11, 2024

Conversation

rundtjan
Copy link
Collaborator

@rundtjan rundtjan commented Jun 5, 2024

@rundtjan rundtjan added the DON'T MERGE BEFORE FD APPROVAL Do not merge until Funidata has removed this label label Jun 5, 2024
@rundtjan rundtjan requested a review from mattirasanen June 5, 2024 06:05
Copy link
Collaborator

@mattirasanen mattirasanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking fetch users from sisu to me. But lets wait atleast one more fd review

Copy link

@VoxBorealis VoxBorealis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@rundtjan rundtjan removed the DON'T MERGE BEFORE FD APPROVAL Do not merge until Funidata has removed this label label Jun 6, 2024
Copy link
Contributor

@rikurauhala rikurauhala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments.

services/backend/src/routes/users.js Outdated Show resolved Hide resolved
services/backend/src/routes/users.js Outdated Show resolved Hide resolved
…here. Add serviceProvider check to routes module
@rikurauhala rikurauhala merged commit 81146f9 into master Jun 11, 2024
13 checks passed
@rikurauhala rikurauhala deleted the OOD-11 branch June 11, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants