[Backend] Fix study guidance group fetching when the user has no sisP…

…ersonId
UniversityOfHelsinkiCS · Nov 28, 2024 · c7b8685 · c7b8685
1 parent afcf72e
commit c7b8685
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/services/backend/src/services/studyGuidanceGroups.ts b/services/backend/src/services/studyGuidanceGroups.ts
@@ -41,7 +41,7 @@ type StudyGuidanceGroup = {
 }
 
 const getGroupsFromImporter = async (sisPersonId: string) => {
-  if (!importerClient) {
+  if (!importerClient || !sisPersonId) {
     return []
   }
   const answerTimeout = new Promise(resolve => setTimeout(resolve, 2000))

diff --git a/services/backend/src/util/jami.ts b/services/backend/src/util/jami.ts
@@ -26,10 +26,11 @@ export const getUserIamAccess = async (
     return {}
   }
   try {
+    const getSisuAccess = !isStaging && sisPersonId != null && sisPersonId !== ''
     const { data: iamAccess } = await jamiClient.post('/', {
       userId: sisPersonId,
       iamGroups,
-      getSisuAccess: !isStaging,
+      getSisuAccess,
     })
     const { specialGroup } = iamAccess as { specialGroup: Record<string, boolean> }
     delete iamAccess.specialGroup