[Faculties] Update headers in 'Students of the faculty' table

UniversityOfHelsinkiCS · Jul 31, 2024 · 676d9dd · 676d9dd
1 parent 51d1f6b
commit 676d9dd
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/services/frontend/src/components/FacultyStatistics/BasicOverview/index.jsx b/services/frontend/src/components/FacultyStatistics/BasicOverview/index.jsx
@@ -114,9 +114,9 @@ export const BasicOverview = ({
   const creditSortingTitles = ['Code', 'Total', 'Degree', 'Exchange', 'Open uni', 'Transferred']
   if (showAll) creditSortingTitles.splice(5, 0, 'Other uni', 'Separate')
 
-  const transferShortTitles = ['Code', 'Started', 'Graduated']
+  const transferShortTitles = ['Code', 'Started', 'Accepted', 'Graduated']
   if (special === 'SPECIAL_INCLUDED') {
-    transferShortTitles.push('Transferred in', 'Transferred away', 'Transferred to')
+    transferShortTitles.push('Transferred out', 'Transferred into')
   }
 
   const options = {

diff --git a/services/frontend/src/components/FacultyStatistics/InteractiveDataView/index.jsx b/services/frontend/src/components/FacultyStatistics/InteractiveDataView/index.jsx
@@ -123,7 +123,7 @@ export const InteractiveDataTable = ({
             color={sorter === sorterName ? 'blue' : 'black'}
             content={sorterName}
             data-cy={`Menu-${cypress}-${sorterName}`}
-            icon={sortDir === 1 ? 'triangle down' : 'triangle up'}
+            icon={sortDir === -1 && sorter === sorterName ? 'triangle up' : 'triangle down'}
             key={sorterName}
             onClick={() => handleClick(sorterName, nameIndex)}
             style={{ borderRadius: '1px', fontSize: '14px', padding: '0 10px' }}

diff --git a/services/frontend/src/components/FacultyStatistics/TimesAndPaths/GraduationTimes.jsx b/services/frontend/src/components/FacultyStatistics/TimesAndPaths/GraduationTimes.jsx
@@ -48,7 +48,7 @@ const MedianDisplay = ({
           universityMode={universityMode}
           yearLabel={yearLabel}
         />
-        {!programmeData ? (
+        {!programmeData || !(year in levelProgrammeData) ? (
           <div className="graduations-message">
             <Message compact>
               Click a bar to view that year's {universityMode ? 'faculty' : 'programme'} level breakdown
@@ -57,7 +57,7 @@ const MedianDisplay = ({
         ) : (
           <MedianBarChart
             classSizes={classSizes?.programmes}
-            data={levelProgrammeData[year]?.data}
+            data={levelProgrammeData[year].data}
             facultyGraph={false}
             goal={goal}
             goalExceptions={goalExceptions}