Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Candidate: 4.1.0-rc1 #1248

Conversation

demiankatz
Copy link
Contributor

@demiankatz demiankatz commented Dec 10, 2024

This PR contains the first release candidate for Universal Viewer 4.1.0. Please test and provide feedback!

Significant changes/new features:

@demiankatz demiankatz marked this pull request as draft December 10, 2024 16:39
Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
universalviewer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 4:40pm

@demiankatz demiankatz changed the base branch from dev to release-4.1.0 December 12, 2024 11:59
@demiankatz demiankatz marked this pull request as ready for review December 12, 2024 12:50
@demiankatz
Copy link
Contributor Author

I'm taking this out of draft mode in light of proposed release process changes in #1252. If we decide to follow the revised process, it should be fine to approve and merge this at any time; the PR will remain useful as a Vercel preview and discussion board whether or not it has been merged.

@mialondon
Copy link
Contributor

As discussed on the Slack, I suggest we don't include the 'home' button in this release, as we're looking at the placement of icons following UX work with Scott Jenson, and it'd be confusing for it to appear then disappear in subsequent releases. It's also slightly confusing as it only resets some of the image manipulation options (zoom and position but not rotate or colour controls), and the 'home' icon generally means 'take me to a home page', not 'reset'.

@demiankatz
Copy link
Contributor Author

@mialondon, I somehow didn't realize that the home button was new to this release; I thought it had always been there! I agree that it doesn't make sense to add it here, and I suspect that its appearance is an accidental side effect of some other change.

@demiankatz
Copy link
Contributor Author

@mialondon, PR #1259 should fix this problem; see the description there for an explanation of exactly what happened.

@demiankatz demiankatz merged commit af87742 into UniversalViewer:release-4.1.0 Dec 19, 2024
5 checks passed
@demiankatz demiankatz deleted the release-candidate-4.1.0-rc1 branch December 19, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants