Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#7 Conversion for Language Level Type #130

Merged

Conversation

ThiBruUU
Copy link
Collaborator

fixes issue #7

Adds some functions as a quickfix to convert the existing feature model into a feature model suitable for the included language levels if language levels are missing (Type, Type.numeric-constraints, Type.string-constraints).

@SundermannC
Copy link
Member

On my system, it seems like the changes are not really robust.
Especially when having constraints and features that illegally use type level, UVLS crashed entirely or shows this message often:
image
It won't leave this state and UVLS appears to be much slower during it. For instance, UVLS requires multiple seconds for a single autocomplete. While it is not 100% deterministic, it happens most of the time for me.

With the master branch, the crashes do not seem to happen for me.

Here is the model:

include
    Boolean
    Arithmetic

features
    Root {Numeric 25}
    Fun {String ''}
    Real noFun

constraints
    noFun > 3

Does this issue occur for you as well?

@MartinMUU
Copy link
Contributor

On my system the changes seem to work as intended. Also the example model is working correctly.

grafik

@SundermannC
Copy link
Member

Strange, did you make edits? For me, I can perform quick fixes initially sometimes, but problems occur consistently within a few small changes.

Could this be related to the OS? Did you introduce any changes to implementation using file system operations?

@MartinMUU
Copy link
Contributor

I tested it again with a lot of changes and edits, but I still can't reproduce the bug. I tested it on Windows.
We did not change anything in relation to the file System as far as I know.

@SundermannC SundermannC changed the base branch from master to conversion-exp March 21, 2024 16:34
@SundermannC SundermannC merged commit f65b4d7 into Universal-Variability-Language:conversion-exp Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants