Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Samsung and AOSP packages. #707

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

schbrns
Copy link
Contributor

@schbrns schbrns commented Nov 2, 2024

No description provided.

Copy link
Contributor

deepsource-io bot commented Nov 2, 2024

Here's the code health analysis summary for commits a25efe0..52f0dc6. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Rust LogoRust✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage⚠️ Artifact not reportedTimed out: Artifact was never reportedView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@zavocc
Copy link

zavocc commented Nov 2, 2024

Some descriptions like risks of removal is useful, is it really confirmed that its not needed?

@schbrns
Copy link
Contributor Author

schbrns commented Nov 2, 2024

Some descriptions like risks of removal is useful, is it really confirmed that its not needed?

Was there ever proof that it was needed? The only place I ever read about those being unsafe was here and it stretches years back.
Somebody probably removed a bootloop overlay like gmsconfig.common/gmsconfig.geotz and copy and pasted it across the board.

These emulation packages are part of the Developer option that allows you to switch cutout type during app testing.
I've removed EMULATION overlays for several years now without issues. The option just disappears from the menu.

com.android.internal.display.cutout.emulation.*

cutout-example-1

A display cutout is an area on some devices that extends into the display surface. It allows for an edge-to-edge experience while providing space for important sensors on the front of the device.

Test all of your app's screens and experiences. Test on devices with different types of cutouts, if possible. If you don't have a device with a cutout, you can simulate common cutout configurations on any device or emulator running Android 9 or higher by doing the following:

Enable Developer options.
In the Developer options screen, scroll down to the Drawing section and select Simulate a display with a cutout.

Select the cutout type.
An image showing how to simulate a display cutout in the emulator
Figure 10. Developer options to test how your content renders.

https://developer.android.com/develop/ui/views/layout/display-cutout

"dependencies": [],
"neededBy": [],
"labels": [],
"removal": "Advanced"
"removal": "Recommended"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"removal": "Recommended"
"removal": "Expert"

Went the wrong way on this one.

"dependencies": [],
"neededBy": [],
"labels": [],
"removal": "Expert"
},
"android.auto_generated_rro_vendor__": {
"list": "Aosp",
"description": "RRO = Runtime Resources Overlay. Used by OEMs to customize look and feel of certain applications.\nhttps://source.android.com/devices/architecture/rros\nhttps://code.tutsplus.com/tutorials/quick-tip-theme-android-with-the-runtime-resource-overlay-framework--cms-29708",
"description": "Auto-generated Vendor Runtime Resource Overlay (RRO).\nBattery drain.\nhttps://cs.android.com/android/platform/superproject/main/+/main:build/make/core/artifact_path_requirements.mk",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"description": "Auto-generated Vendor Runtime Resource Overlay (RRO).\nBattery drain.\nhttps://cs.android.com/android/platform/superproject/main/+/main:build/make/core/artifact_path_requirements.mk",
"description": "Auto-generated Vendor Runtime Resource Overlay (RRO).\nRemoving may cause more battery drain.\nhttps://cs.android.com/android/platform/superproject/main/+/main:build/make/core/artifact_path_requirements.mk",

@schbrns schbrns marked this pull request as draft November 5, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants