-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Samsung and AOSP packages. #707
base: main
Are you sure you want to change the base?
Conversation
Here's the code health analysis summary for commits Analysis Summary
|
Some descriptions like risks of removal is useful, is it really confirmed that its not needed? |
Was there ever proof that it was needed? The only place I ever read about those being unsafe was here and it stretches years back. These
https://developer.android.com/develop/ui/views/layout/display-cutout |
"dependencies": [], | ||
"neededBy": [], | ||
"labels": [], | ||
"removal": "Advanced" | ||
"removal": "Recommended" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"removal": "Recommended" | |
"removal": "Expert" |
Went the wrong way on this one.
"dependencies": [], | ||
"neededBy": [], | ||
"labels": [], | ||
"removal": "Expert" | ||
}, | ||
"android.auto_generated_rro_vendor__": { | ||
"list": "Aosp", | ||
"description": "RRO = Runtime Resources Overlay. Used by OEMs to customize look and feel of certain applications.\nhttps://source.android.com/devices/architecture/rros\nhttps://code.tutsplus.com/tutorials/quick-tip-theme-android-with-the-runtime-resource-overlay-framework--cms-29708", | ||
"description": "Auto-generated Vendor Runtime Resource Overlay (RRO).\nBattery drain.\nhttps://cs.android.com/android/platform/superproject/main/+/main:build/make/core/artifact_path_requirements.mk", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"description": "Auto-generated Vendor Runtime Resource Overlay (RRO).\nBattery drain.\nhttps://cs.android.com/android/platform/superproject/main/+/main:build/make/core/artifact_path_requirements.mk", | |
"description": "Auto-generated Vendor Runtime Resource Overlay (RRO).\nRemoving may cause more battery drain.\nhttps://cs.android.com/android/platform/superproject/main/+/main:build/make/core/artifact_path_requirements.mk", |
No description provided.