fix: update universal rpc tests revert spawnmany timeout #3168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoelStephensUnity
deleted the
fix/update-universal-rpc-tests-revert-spawnmany-timeout
branch
michalChrobot
pushed a commit
that referenced
this pull request
Dec 12, 2024
* update reverting the removal of the timeout. making it actually 6 minutes. * fix Using the NGO v2. version of the UniversalRpcTestSendingWithGroupNotOverride and TestSendingWithGroupOverride tests.
michalChrobot
added a commit
that referenced
this pull request
Dec 15, 2024
) * Added setup necessary for release automation of NGO (#3141) * Corrected license file * Removed old files not conforming to pvp rules * Corrected typo in changelog * Added samples description to package.json while removing deprecated .samples.json * Inclusion of CI generation files * Changed Samples folder name to Samples~ * Added path field in package.json for samples * fix: removing timeouts from integration tests (#3167) Removing timesouts from our integration tests: - TestSendingWithGroupOverride - TestSendingWithGroupNotOverride - WhenManyObjectsAreSpawnedAtOnce_AllAreReceived( * fix: update universal rpc tests revert spawnmany timeout (#3168) * fix: adding extended timeout to all universal rpc tests (#3170) Adding extended timeout to all universal rpc tests * Extended timeout for validation jobs on editors lower than 6000 to 5h (#3173) --------- Co-authored-by: Noel Stephens <[email protected]>
NoelStephensUnity
added a commit
that referenced
this pull request
Jan 10, 2025
* update incrementing the version number and updating changelog to match version number. * Added setup necessary for release automation of NGO (#3141) generated files for release automation within Unity org * fix: networklist editor memory leak [backport] (#3148) * fix This fixes the issue with NetworkLists on in-scene placed NetworkObjects causing small memory leaks when entering and exiting playmode. * update adding changelog entry * update adding PR number to log entry * Corrected setup necessary for release automation of NGO (#3149) * generated files for release automation within Unity org * Corrected pvp profiles check * Chore/phase 1 api documentation update 1 12 0 (#3158) * Update README.md Adding note about where to find the NGO v2 branch along with the examples. * chore: api documentation phase 1 [backport] (#3157) * update updating XML API documentation for ConnectionEvent and ConnectionEventData. * update Updating XML API documentation for RpcTargetUse. * Update com.unity.netcode.gameobjects/Runtime/Messaging/RpcTargets/RpcTarget.cs Co-authored-by: Emma <[email protected]> * Update com.unity.netcode.gameobjects/Runtime/Messaging/RpcTargets/RpcTarget.cs Co-authored-by: Emma <[email protected]> --------- Co-authored-by: Emma <[email protected]> --------- Co-authored-by: Emma <[email protected]> * PVP and Wrench fixes * Updated wrench version to 0.10.30 * Corrected license file * Removed old files not conforming to pvp rules * Corrected typo in changelog * Added samples description to package.json while removing deprecated .samples.json * Inclusion of CI generation files * Pvp fixes for automated release * Changed Samples folder name to Samples~ * Added path field in package.json for samples * Increased wrench timeout for editors below 6000 * Increasing wrench timeout to 2h for wrench validation jobs * Timeout of validation jobs increased to 2h for editors below 6000 * fix: removing timeouts from integration tests (#3167) fix Removing timesouts from our integration tests: - TestSendingWithGroupOverride - TestSendingWithGroupNotOverride - WhenManyObjectsAreSpawnedAtOnce_AllAreReceived( * fix: update universal rpc tests revert spawnmany timeout (#3168) * update reverting the removal of the timeout. making it actually 6 minutes. * fix Using the NGO v2. version of the UniversalRpcTestSendingWithGroupNotOverride and TestSendingWithGroupOverride tests. * fix (#3169) ignoring the two failing tests. * fix: adding extended timeout to all universal rpc tests (#3170) fix Adding extended timeout to all universal rpc tests * Extended timeout for validation jobs on editors lower than 6000 to 5h (#3173) * update Adding change log entry for this PR. * update removing changelog entry as that belong to a different PR. --------- Co-authored-by: Michał Chrobot <[email protected]> Co-authored-by: Emma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverting the change in timeout for WhenManyObjectsAreSpawnedAtOnce_AllAreReceived.
Using NGO v2 version of:
And bumping the timeout to 20 minutes.
Changelog
NA
Testing and Documentation