fix: distributed authority spawning prefab overrides #3160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed issue with server only NetworkManager instance spawning the network prefab itself as opposed to creating an instance. Extracted the instantiation portion of a network prefab into an internal method that can be used for integration testing prefab instantiation and potentially other edge case scenarios.
Migrated all runtime network prefab related tests into a Prefabs subfolder. Added new NetworkPrefabOverrideTests to validate the actual spawned instances on all clients using both client-server and distributed authority network topologies. Added helper method `NettcodeIntegrationTestHelpers.CreateNetworkObject`.
NoelStephensUnity
deleted the
fix/distributed-authrity-prefab-override
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves an issue discovered in NGO example (#3161) where only the session owner would use the proper base
GlobalObjectIdHashwhen spawning prefab overrides. Now, all clients are treated like a host (regarding spawning and prefab overrides) and will use the baseGlobalObjectIdHashvalue when sending aCreateObjectMessage.This PR also resolves a discovered issue where a server-only
NetworkManagerinstance could spawn the network prefab instance itself as opposed to making an instance of the prefab and spawning the new instance.Changelog
NetworkManagerinstance would spawn the actualNetworkPrefab'sGameObjectas opposed to creating an instance of it.Testing and Documentation
NetworkPrefabHandlerTests.NetworkPrefabHandlerClassNetworkPrefabOverrideTestsintegration test.