Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: in-sceneobject NetworkObject update in editor tool (up-port) #3092

Merged
merged 3 commits into from
Oct 10, 2024
Merged

fix: in-sceneobject NetworkObject update in editor tool (up-port) #3092

merged 3 commits into from
Oct 10, 2024

Conversation

NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented Oct 8, 2024 •
edited
Loading

Up-port of #3084
This resolves an issue with the in-scene network prefab instance update menu tool where it was not properly updating scenes when invoked on the root prefab instance.

MTTB-485

fix: #3067

Changelog

  • Fixed: Issue with the in-scene network prefab instance update menu tool where it was not properly updating scenes when invoked on the root prefab instance.

Testing and Documentation

  • No tests have been added.
  • No documentation changes or additions were necessary.

@NoelStephensUnity
update
e4aa54b 
Update to NetworkObject to assist with the refresh in-scene prefab instances
@NoelStephensUnity
fix
2d4c28d 
Fixing issue where updating a prefab used as in-scene placed prefab instance(s) would not properly get updated if the root prefab asset was updated to have a NetworkObject component.
@NoelStephensUnity
update
1f20e33 
changelog entry
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review October 8, 2024 21:42
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner October 8, 2024 21:42
@NoelStephensUnity NoelStephensUnity merged commit 058481b into develop-2.0.0 Oct 10, 2024
24 checks passed
@NoelStephensUnity NoelStephensUnity deleted the fix/in-sceneobject-networkobject-update-in-editor-tool-up-port branch October 10, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fluong6 fluong6 fluong6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NoelStephensUnity @fluong6