Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: networkanimator only updates observers #3057

Merged
merged 3 commits into from
Sep 10, 2024
Merged

fix: networkanimator only updates observers #3057

merged 3 commits into from
Sep 10, 2024

Conversation

NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented Sep 10, 2024 •
edited
Loading

This resolves the issue with NetworkAnimator sending animation updates to non-observers.
(#3058 is the v1.12.0 backport of this fix)

MTTB-2

fix: #2793

Changelog

  • Fixed: Issue where NetworkAnimator would send updates to non-observer clients.

Testing and Documentation

  • Includes integration test NetworkAnimator.OnlyObserversAnimateTest.
  • No documentation changes or additions were necessary.

@NoelStephensUnity
fix
598da27 
Only send updates to observers.
@NoelStephensUnity
test
6138033 
Includes validation test that it only sends updates to observers.
@NoelStephensUnity
update
e014f9f 
adding changelog entry.
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review September 10, 2024 15:51
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner September 10, 2024 15:51
@NoelStephensUnity NoelStephensUnity mentioned this pull request Sep 10, 2024
Merged
@NoelStephensUnity NoelStephensUnity merged commit 31c30e5 into develop-2.0.0 Sep 10, 2024
24 checks passed
@NoelStephensUnity NoelStephensUnity deleted the fix/networkanimator-only-updates-observers branch September 10, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@NoelStephensUnity