Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exception thrown when rpc received for depsawned object (back-port) #3055

Conversation

NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented Sep 9, 2024

Backported from #3052
This resolves the issue where an exception is thrown if universal RPC is received after a NetworkObject has been despawned. Now it logs a warning if developer logging is enabled otherwise it just silently ignores the RPC.

MTTB-361
fix: #3007

Changelog

  • Fixed: Issue where an exception could occur when receiving a universal RPC for a NetworkObject that has been despawned.

Testing and Documentation

  • No tests have been added.
  • No documentation changes or additions were necessary.

We should not throw an exception if an RPC is received and the target NetworkObject does not exist as it could have been despawned.
Adding changelog entry
adding changelog entry PR number.
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review September 9, 2024 16:23
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner September 9, 2024 16:23
@NoelStephensUnity NoelStephensUnity changed the title fix: exception thrown when rpc received for depsawned object fix: exception thrown when rpc received for depsawned object (back-port) Sep 9, 2024
@NoelStephensUnity NoelStephensUnity enabled auto-merge (squash) September 9, 2024 16:25
removing using directive.
@NoelStephensUnity NoelStephensUnity merged commit 39818f2 into develop Sep 9, 2024
24 checks passed
@NoelStephensUnity NoelStephensUnity deleted the fix/exception-thrown-when-rpc-received-depsawned-object branch September 9, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remote client can send RPC to NetworkObject that has been despawned on host, resulting in error
2 participants