Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: NetworkTransform half float synch #2791

Merged
merged 3 commits into from
Dec 13, 2023

Conversation

NoelStephensUnity
Copy link
Collaborator

Fixes the issue found when running through the play test where when UseUnreliableDeltas was enabled and a NetworkTransform was using half float precision the NetworkDeltaPosition was not synchronizing the base position during an axial frame synch.

Changelog

NA

Testing and Documentation

  • No tests have been added.
  • No documentation changes or additions were necessary.

Fixing the issue with HalfFloat position not keeping the base position synchronized when using unreliable deltas.
adding comment
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner December 12, 2023 22:23
@NoelStephensUnity NoelStephensUnity enabled auto-merge (squash) December 13, 2023 15:22
@NoelStephensUnity NoelStephensUnity merged commit 53b735c into develop Dec 13, 2023
23 checks passed
@NoelStephensUnity NoelStephensUnity deleted the fix/networktransform-halffloat-synch branch December 13, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants