feat: Support for generic NetworkBehaviour types, and fix: issues with domain reload/scene reload being disabled #2720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samlucas-unity
approved these changes
Oct 3, 2023
|
Any idea when this would be released? |
|
@RubenCoucke I cannot give you an exact date, but this should be included in our next release, which should be coming out relatively soon. |
NoelStephensUnity
pushed a commit
that referenced
this pull request
Oct 5, 2023
…h domain reload/scene reload being disabled (#2720) Adds support for generic network behaviours, as well as for serializing generic types in RPCs (so long as the type is defined on the behaviour and not on the RPC itself; which is to say, this is supported: ```csharp public class Foo<T> : NetworkBehaviour { [ServerRpc] public void MyServerRpc(T val) {} } ``` But this is not: ```csharp public class Foo : NetworkBehaviour { [ServerRpc] public void MyServerRpc<T>(T val) {} } ``` As in the former case, when the class is instantiated, it knows what T is and there is only one version of the RPC per class, while the latter case would require much more significant plumbing for runtime type identification of RPC parameters in order to be able to instantiate the RPC correctly on the receiving side.) In fixing this, the majority of the issues with domain reload were also fixed coincidentally, so I went ahead and fixed the couple of remaining issues as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for generic network behaviours, as well as for serializing generic types in RPCs (so long as the type is defined on the behaviour and not on the RPC itself; which is to say, this is supported:
But this is not:
As in the former case, when the class is instantiated, it knows what T is and there is only one version of the RPC per class, while the latter case would require much more significant plumbing for runtime type identification of RPC parameters in order to be able to instantiate the RPC correctly on the receiving side.)
In fixing this, the majority of the issues with domain reload were also fixed coincidentally, so I went ahead and fixed the couple of remaining issues as well.
Changelog
NetworkBehaviourtypes no longer result in compile errors or runtime errorsTesting and Documentation
fixes #1860
fixes #1879
fixes #2118
fixes #2608
fixes #2633
fixes #2647
fixes #2690
fixes #2693
fixes #2717
fixes #2719