Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #3456 Make module installation work on windows. #3495

Merged
merged 4 commits into from
Mar 2, 2018
Merged

fix: #3456 Make module installation work on windows. #3495

merged 4 commits into from
Mar 2, 2018

Conversation

wallet77
Copy link
Contributor

Make module installation work on windows.

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #3456
License MIT
Doc PR https://github.com/pm2-hive/pm2-hive.github.io/pulls

@wallet77 wallet77 requested a review from vmarchaud February 26, 2018 13:48
@vmarchaud
Copy link
Contributor

Note that homeDir require node > 2.3 so it will only land for PM2 3

@wallet77 wallet77 merged commit e9c625d into development Mar 2, 2018
@wallet77 wallet77 deleted the module_install_windows branch March 15, 2018 12:42
@vmarchaud vmarchaud mentioned this pull request Apr 2, 2018
Closed
inerc pushed a commit to inerc/pm2 that referenced this pull request Feb 11, 2020
@wallet77
Merge pull request Unitech#3495 from Unitech/module_install_windows
65aa50e 
fix: Unitech#3456 Make module installation work on windows.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmarchaud vmarchaud vmarchaud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wallet77 @vmarchaud