max_memory_restart in StartOptions should be string, not number

[cfi2017]

What's going wrong?

The interface StartOptions defines max_memory_restart to be a number. This causes transpiling to fail when trying to set the value to something like '200M' or '2G'.

pm2/types/index.d.ts

Line 351 in 5a8dd7d

max_memory_restart?: number;

How could we reproduce this issue?

Try using the pm2 api with TypeScript and starting a process.

Supporting information

Additionally, it does not seem like autorestart is defined as a value of StartOptions.

pm2 report output:

===============================================================================
--- PM2 REPORT (Tue Aug 28 2018 15:18:49 GMT+0200 (Central European Summer Time)) 
===============================================================================
--- Daemon -------------------------------------------------
pm2d version         : 3.0.3
node version         : 10.8.0
node path            : /Users/cfi/.nvm/versions/node/v10.8.0/bin/pm2
argv                 : /Users/cfi/.nvm/versions/node/v10.8.0/bin/node,/Users/cfi/.nvm/versions/node/v10.8.0/lib/node_modules/pm2/lib/Daemon.js
argv0                : node
user                 : cfi
uid                  : 501
gid                  : 20
uptime               : 18881min
===============================================================================
--- CLI ----------------------------------------------------
local pm2            : 3.0.3
node version         : 10.8.0
node path            : /Users/cfi/.nvm/versions/node/v10.8.0/bin/pm2
argv                 : /Users/cfi/.nvm/versions/node/v10.8.0/bin/node,/Users/cfi/.nvm/versions/node/v10.8.0/bin/pm2,report
argv0                : node
user                 : cfi
uid                  : 501
gid                  : 20
===============================================================================
--- System info --------------------------------------------
arch                 : x64
platform             : darwin
type                 : Darwin
cpus                 : Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz
cpus nb              : 12
freemem              : 437809152
totalmem             : 17179869184
home                 : /Users/cfi
===============================================================================

[cfi2017]

After reading through the source, it seems to default to bytes, so I'm using those for now.

Additionally, it seems wait_ready is not currently supported either.

[wallet77]

Hi @cfi2017

What do you mean by wait_ready is not supported ?
Not defined as a type or not available with API ?

[cfi2017]

It doesn't look like it's defined as a type. It seems to work if I create a startOptions object like this:

const startOptions: StartOptions = {} as StartOptions;

and then add wait_ready like this:

startOptions['wait_ready'] = true;

Additionally, it seems I can add max_memory_restart as a number (4294967296), but it doesn't seem to affect the actual configuration.

My full configuration and launching script is as follows: (In this example, max_memory_restart has no effect.)

const startOptions: StartOptions = {
  script: 'target/index.js',
  name: 'Worker#' + workerNumber,
  kill_timeout: 30000,
  watch: true,
  max_memory_restart: 4294967296,
  autorestart: false,
  env: {
    NODE_ENV: 'development'
  },
  args: [output, '--deleteOutput=' + options.deleteOutput, '--selfLaunched']
} as StartOptions;

startOptions['wait_ready'] = true;

pm2.start(startOptions, (err2, apps) => {
  // Post-initialization code
});