Fix int
overflow in TraceCollector.hash()
#172
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java interprets
(int) x % capacity
as((int) x) % capacity
. Therefore, whenever 33-rd bit ofx
is1
, then((int) x)
is negative and hence(int) x % capacity
is also negative and can't be used as an array index.In the current implementation 5-th byte of
key
stores the lower byte of themethodId: Long
, meaning that for classes with over 128 methods 33-rd bit ofkey
can be1
, which ultimately causesjcInstructionCovered()
to fail withIndexOutOfBoundsException
.