Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: gasUsed and gasPrice in Transaction #12

Merged
merged 1 commit into from
May 23, 2021
Merged

feat: gasUsed and gasPrice in Transaction #12

merged 1 commit into from
May 23, 2021

Conversation

benesjan
Copy link
Contributor

@benesjan benesjan commented May 19, 2021 •
edited
Loading

Adding fields to Transaction entity which help with accounting for tx cost.

ianlapham
ianlapham approved these changes May 23, 2021
View reviewed changes
Copy link
Member

@ianlapham ianlapham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ianlapham
ianlapham approved these changes May 23, 2021
View reviewed changes
Copy link
Member

@ianlapham ianlapham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ianlapham ianlapham merged commit 3286d8c into Uniswap:main May 23, 2021
@benesjan benesjan deleted the feat/gasinfo-in-tx branch May 27, 2021 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianlapham ianlapham ianlapham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benesjan @ianlapham