feat: add financial council #1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Тестов к этому пока нет? |
|
@uandysmith могу написать дополнительные gov-тесты, но надо подтверждение, что настройка по управлению составом фин-комма удовлетворяет. И что прайм-голос можно поставить с помощью >50% обычного Совета |
mrshiposha
force-pushed
the
feature/financial-council
branch
from
3fb7ec9 to
d9af4ae
Compare
test: add techComm+finCouncil tests, remove duplicates
CertainLach
reviewed
Jun 5, 2024
mrshiposha
commented
Jun 5, 2024
js-packages/test-utils/util.ts
Outdated
| @@ -117,6 +117,7 @@ export enum Pallets { | |||
| Identity = 'identity', | |||
| Democracy = 'democracy', | |||
| Council = 'council', | |||
| FinancialCouncil = 'financialcouncil', | |||
| //CouncilMembership = 'councilmembership', | |||
| )).to.be.rejectedWith('BadOrigin'); | ||
| }); | ||
|
|
||
| itSub('[Negative] FinCouncil member can\'t add a Fellowship member', async ({helper}) => { |
There was a problem hiding this comment.
Для всего FinCouncil теста нет. Хотя, наверное, это было бы избыточно
| await proposalFromAllCommittee(addMemberProposal); | ||
|
|
||
| const finCouncilMembers = await helper.finCouncil.membership.getMembers(); | ||
| expect(finCouncilMembers).to.contains(newFinCouncilMember.address); |
There was a problem hiding this comment.
Ощущение, что это неправильно. Пропущен "not"?
uandysmith
approved these changes
Jun 13, 2024
CertainLach
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.