feat: add ApplyAuthorizedUpgradeOrigin

bridges/snowbridge/parachain/pallets/ethereum-beacon-client/src/mock.rs

@@ -205,6 +205,7 @@ pub mod mainnet {
 	impl frame_system::Config for Test {
 		type BaseCallFilter = frame_support::traits::Everything;
 		type OnSetCode = ();
+		type ApplyAuthorizedUpgradeOrigin = frame_system::EnsureAlways;
 		type BlockWeights = ();
 		type BlockLength = ();
 		type DbWeight = ();

bridges/snowbridge/parachain/pallets/inbound-queue/src/mock.rs

@@ -68,6 +68,7 @@ impl frame_system::Config for Test {
 	type SystemWeightInfo = ();
 	type SS58Prefix = ();
 	type OnSetCode = ();
+	type ApplyAuthorizedUpgradeOrigin = frame_system::EnsureAlways;
 	type MaxConsumers = frame_support::traits::ConstU32<16>;
 	type Nonce = u64;
 	type Block = Block;

bridges/snowbridge/parachain/pallets/outbound-queue/src/mock.rs

@@ -59,6 +59,7 @@ impl frame_system::Config for Test {
 	type SystemWeightInfo = ();
 	type SS58Prefix = ();
 	type OnSetCode = ();
+	type ApplyAuthorizedUpgradeOrigin = frame_system::EnsureAlways;
 	type MaxConsumers = frame_support::traits::ConstU32<16>;
 	type Nonce = u64;
 	type Block = Block;

bridges/snowbridge/parachain/pallets/system/src/mock.rs

@@ -117,6 +117,7 @@ impl frame_system::Config for Test {
 	type SystemWeightInfo = ();
 	type SS58Prefix = ConstU16<42>;
 	type OnSetCode = ();
+	type ApplyAuthorizedUpgradeOrigin = frame_system::EnsureAlways;
 	type MaxConsumers = frame_support::traits::ConstU32<16>;
 	type Nonce = u64;
 	type Block = Block;

cumulus/pallets/parachain-system/src/lib.rs

@@ -693,9 +693,10 @@ pub mod pallet {
 			note = "To be removed after June 2024. Migrate to `frame_system::apply_authorized_upgrade`."
 		)]
 		pub fn enact_authorized_upgrade(
-			_: OriginFor<T>,
+			origin: OriginFor<T>,
 			code: Vec<u8>,
 		) -> DispatchResultWithPostInfo {
+			<T as frame_system::Config>::ApplyAuthorizedUpgradeOrigin::ensure_origin(origin)?;
 			let post = frame_system::Pallet::<T>::do_apply_authorize_upgrade(code)?;
 			Ok(post)
 		}

substrate/frame/system/src/lib.rs

@@ -257,7 +257,7 @@ pub mod pallet {
 
 	/// Default implementations of [`DefaultConfig`], which can be used to implement [`Config`].
 	pub mod config_preludes {
-		use super::{inject_runtime_type, DefaultConfig};
+		use super::{inject_runtime_type, DefaultConfig, EnsureAlways};
 		use frame_support::derive_impl;
 
 		/// Provides a viable default config that can be used with
@@ -298,6 +298,7 @@ pub mod pallet {
 			type BaseCallFilter = frame_support::traits::Everything;
 			type BlockHashCount = frame_support::traits::ConstU64<10>;
 			type OnSetCode = ();
+			type ApplyAuthorizedUpgradeOrigin = EnsureAlways;
 		}
 
 		/// Default configurations of this pallet in a solo-chain environment.
@@ -392,6 +393,8 @@ pub mod pallet {
 
 			/// The set code logic, just the default since we're not a parachain.
 			type OnSetCode = ();
+
+			type ApplyAuthorizedUpgradeOrigin = EnsureAlways;
 		}
 
 		/// Default configurations of this pallet in a relay-chain environment.
@@ -568,6 +571,8 @@ pub mod pallet {
 		#[pallet::no_default_bounds]
 		type OnSetCode: SetCode<Self>;
 
+		type ApplyAuthorizedUpgradeOrigin: EnsureOrigin<Self::RuntimeOrigin>;
+
 		/// The maximum number of consumers allowed on a single account.
 		type MaxConsumers: ConsumerLimits;
 	}
@@ -757,9 +762,10 @@ pub mod pallet {
 		#[pallet::call_index(11)]
 		#[pallet::weight((T::SystemWeightInfo::apply_authorized_upgrade(), DispatchClass::Operational))]
 		pub fn apply_authorized_upgrade(
-			_: OriginFor<T>,
+			origin: OriginFor<T>,
 			code: Vec<u8>,
 		) -> DispatchResultWithPostInfo {
+			T::ApplyAuthorizedUpgradeOrigin::ensure_origin(origin)?;
 			let post = Self::do_apply_authorize_upgrade(code)?;
 			Ok(post)
 		}
@@ -1259,6 +1265,20 @@ impl_ensure_origin_with_arg_ignoring_arg! {
 	{}
 }
 
+/// Always pass.
+pub struct EnsureAlways;
+impl<O> EnsureOrigin<O> for EnsureAlways {
+	type Success = ();
+	fn try_origin(_: O) -> Result<(), O> {
+		Ok(())
+	}
+
+	#[cfg(feature = "runtime-benchmarks")]
+	fn try_successful_origin() -> Result<O, ()> {
+		Ok(O::from(RawOrigin::None))
+	}
+}
+
 #[docify::export]
 /// Ensure that the origin `o` represents a signed extrinsic (i.e. transaction).
 /// Returns `Ok` with the account that signed the extrinsic or an `Err` otherwise.