-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable deleting of default dashboard #3233
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Test results 9 files 9 suites 8m 8s ⏱️ Results for commit 6c55c5a. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3233 +/- ##
=======================================
Coverage 60.40% 60.40%
=======================================
Files 605 605
Lines 43683 43685 +2
Branches 48 48
=======================================
+ Hits 26385 26388 +3
+ Misses 17286 17285 -1
Partials 12 12 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
561f1c3
to
1162b47
Compare
Is the end goal avoiding the default dashboard from being deleted, or avoiding that there is no default dashboard? #3150 described the expected behaviour to be that if the original dashboard is deleted, then another dashboard (assuming there are more than one) should become the new default. So if someone has 2 dashboard, then its fine for the default to be deleted. Assuming that is how we want to solve this, I feel like the error message should be something along the lines of "You cannot delete your last dashboard", since there situations where it actually is okay to delete the dashboard |
I will edit the original issue, because in the meantime @lunkwill42 and I decided it is better to outright disable deletion of the default dashboard. Another part of fixing this that is on the way is adding two migrations that will ensure that after applying them every user will have exactly one dashboard. |
c499d88
to
7720f56
Compare
1162b47
to
6c55c5a
Compare
Quality Gate passedIssues Measures |
This will disable deleting of a dashboard if it is the default on and show an alert box why it was not possible to delete the dashboard.