Create event when chassis or module is removed manually #2998
Conversation
stveit
force-pushed
the
feature/create-event-when-chassis-or-module-is-removed-manually
branch
from
f9636d2 to
10065b5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2998 +/- ##
==========================================
- Coverage 60.48% 60.47% -0.01%
==========================================
Files 604 604
Lines 43801 43816 +15
Branches 48 48
==========================================
+ Hits 26491 26497 +6
- Misses 17298 17307 +9
Partials 12 12 ☔ View full report in Codecov by Sentry. |
stveit
force-pushed
the
feature/create-event-when-chassis-or-module-is-removed-manually
branch
from
10065b5 to
5b70fc4
Compare
stveit
force-pushed
the
feature/create-event-when-chassis-or-module-is-removed-manually
branch
from
61460f3 to
3118c78
Compare
| -- Add new deviceState alert | ||
| INSERT INTO alerttype (eventtypeid,alerttype,alerttypedesc) VALUES | ||
| ('deviceState','deviceDeletedChassis','The device has been removed as a chassis.'); | ||
| INSERT INTO alerttype (eventtypeid,alerttype,alerttypedesc) VALUES | ||
| ('deviceState','deviceDeletedModule','The device has been removed as a module.'); |
There was a problem hiding this comment.
Come to think of it, I think I forgot to look at this in your previous PR. 5.10 is the current stable release, this will only hit 5.11, so the migration script should be named differently...
There was a problem hiding this comment.
I just found out that I was unable to merge 5.10.x back into master because the OUI changescript and a bugfix from 5.10 had conflicting changescript names. I had to forcibly rename the OUI script on master, so there may be breakage for devs that do not wipe and re-create their postgres databases.
There was a problem hiding this comment.
yeah fuked up the filename quite hard for PowerSupplyAndFan aswell
stveit
force-pushed
the
feature/create-event-when-chassis-or-module-is-removed-manually
branch
from
0e42d37 to
44ee21d
Compare
stveit
force-pushed
the
feature/create-event-when-chassis-or-module-is-removed-manually
branch
from
44ee21d to
73739ee
Compare
|
stveit
deleted the
feature/create-event-when-chassis-or-module-is-removed-manually
branch
Fixes #2983