Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove customization for definition lists #2868

Merged

Conversation

johannaengland
Copy link
Contributor

@johannaengland johannaengland commented Mar 7, 2024

Find an example here: https://nav--2868.org.readthedocs.build/en/2868/hacking/using-docker.html#using-the-container-s

It does not look the same as with the bootstrap theme, but I find it still neat and clear.

@johannaengland johannaengland added documentation Related to documentation of NAV frontend labels Mar 7, 2024
@johannaengland johannaengland self-assigned this Mar 7, 2024
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.69%. Comparing base (9cfd877) to head (739c730).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2868   +/-   ##
=======================================
  Coverage   56.69%   56.69%           
=======================================
  Files         602      602           
  Lines       43971    43971           
=======================================
  Hits        24931    24931           
  Misses      19040    19040           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Mar 7, 2024

Test results

     12 files       12 suites   11m 27s ⏱️
3 320 tests 3 320 ✔️ 0 💤 0
9 435 runs  9 435 ✔️ 0 💤 0

Results for commit 739c730.

Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't need to look like the bootstrap theme, but it needs to be neat and clean, without weird spacing, alignment and text wrapping issued :)

@johannaengland johannaengland merged commit 0e9f9dc into Uninett:master Mar 7, 2024
11 checks passed
@johannaengland johannaengland deleted the docs/definition-lists branch March 7, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to documentation of NAV frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants