Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nonsensical pydantic requirement #2867

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

lunkwill42
Copy link
Member

For some unknown reason, pydantic was added to the dependency list in pyproject.toml, but NAV has no such dependency. This removes it.

For some unknown reason, pydantic was added to the dependency list
in pyproject.toml, but NAV has no such dependency.  This removes it.
@lunkwill42 lunkwill42 self-assigned this Mar 6, 2024
Copy link

sonarqubecloud bot commented Mar 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.18%. Comparing base (16d3c1b) to head (f426a1a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2867   +/-   ##
=======================================
  Coverage   57.18%   57.18%           
=======================================
  Files         568      568           
  Lines       41299    41299           
=======================================
  Hits        23615    23615           
  Misses      17684    17684           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Mar 6, 2024

Test results

     12 files       12 suites   12m 3s ⏱️
3 312 tests 3 312 ✔️ 0 💤 0
9 411 runs  9 411 ✔️ 0 💤 0

Results for commit f426a1a.

@lunkwill42 lunkwill42 merged commit 3c4f8bd into Uninett:master Mar 7, 2024
12 checks passed
@lunkwill42 lunkwill42 deleted the bugfix/remove-pydantic branch March 7, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants