Install Node/NPM in docker dev environment #2855
Conversation
We are working on replacing SASS compilation (and later JS bundling) with webpack, which will require Node and NPM. This change adds these tools to the Docker-based development environment so everything can be built there.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2855 +/- ##
=======================================
Coverage 57.16% 57.16%
=======================================
Files 568 568
Lines 41293 41293
=======================================
Hits 23607 23607
Misses 17686 17686 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
After rebasing #2849 onto this branch, and testing npm commands, I get /bin/sh: 1: npm: not found after all. So something is off with Node.js in the image
Not reproducible for me. Are you sure you remembered to run |
The deb.nodesource.com archives only publish NodeJS packages for the amd64 architecture. Attempting to build this Dockerfile on a Apple silicon Mac (aarch64 architecture) will result in an image that pulls the incorrect version of `nodejs` from deb.debian.org instead.
|
Turns out @podliashanyk is on a Mac with an M2 chip, and the deb.nodesource.com archives do not publish NodeJS packages for this platform. Added 950d514 to deal with this. |
We are working on replacing SASS compilation (and later JS bundling) with webpack, which will require Node and NPM. This change adds these tools to the Docker-based development environment so everything can be built there.
This is needed for #2849 to be completed.