-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use read the docs sphinx theme instead of bootstrap theme #2825
Use read the docs sphinx theme instead of bootstrap theme #2825
Conversation
b6c6cd0
to
267663a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2825 +/- ##
=======================================
Coverage 57.10% 57.10%
=======================================
Files 567 567
Lines 41278 41278
=======================================
Hits 23571 23571
Misses 17707 17707 ☔ View full report in Codecov by Sentry. |
c4856b1
to
a9d9236
Compare
The easiest way to check the result of this PR is to visit https://nav--2825.org.readthedocs.build/en/2825/ btw, readthedocs builds the docs for us. |
I think it looks perfectly fine as is. @lunkwill42? |
Looks perfectly cromulent to me. And this theme is more likely to be maintained as well. If we can somehow get the logo back on small screen views, that would also be great :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it. Feels easier to navigate since i'm already used to the readthedocs format from other documentations. When using the old NAV docs i usually have to search to find anything, but this I feel can actually be navigated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Some things could be improved, but nothing critical:
- Agree with @lunkwill42's comment about the logo.
- This theme introduces new contrast errors, f.e. in the footer text.
a9d9236
to
34979a3
Compare
Quality Gate passedIssues Measures |
Closes #2805.